[Newton] Drop the unused lockfile input from the kit-less build - #6823
Draft
hujc7 wants to merge 1 commit into
Draft
[Newton] Drop the unused lockfile input from the kit-less build#6823hujc7 wants to merge 1 commit into
hujc7 wants to merge 1 commit into
Conversation
github-actions
Bot
added
documentation
Nothing in the kit-less image reads uv.lock: the build installs through isaaclab.sh, which resolves dependencies with uv pip. The file was still copied into the build context alongside pyproject.toml, so every lockfile change invalidated the dependency layer and forced a full reinstall. Remove it from the COPY and, for the same reason, from the workflow's change-detection patterns; a lockfile-only change cannot produce a different image. pyproject.toml and the package manifests still gate the build.
hujc7
force-pushed
the
jichuanh/kitless-docs-followup
branch
from
July 31, 2026 08:56
9315d69 to
fd29f15
Compare
hujc7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Summary
uv.lockinto the kit-less build context, and stops gating the kit-less CI job on it.2. Background
#6355 — "[Newton] Add a kitless training container" — installs through
"${ISAACLAB_PATH}/isaaclab.sh" --install newton,rl[all],ov[ovrtx], matchingDockerfile.baseandDockerfile.curobo. That path goes throughuv pip, which does not readuv.lock; there is nouv syncor--frozenleft in the Dockerfile.3. Details
uv.lockwas still copied in the same layer aspyproject.toml. Nothing reads it, but aCOPYmakes a file part of the build cache key regardless, so every lockfile change invalidated that layer and forced a full dependency reinstall.The workflow's change-detection pattern had the same problem in reverse: a lockfile-only change triggered a GPU build that could not produce a different image.
pyproject.tomland the per-package manifests still gate the build, which is whatuv pip install --editableactually resolves from.4. Test plan
isaaclab.sh, the install CLI,Dockerfile.kitlessorvalidate-kitless-imagereadsuv.lock,uv sync,uv runor--frozen.docker/test/test_container_profiles.py+docker/test/test_dockerfile_nonroot.py: 30 passed.uv run isaaclab -fon all files.tools/changelog/cli.py check— nosource/<pkg>/touched, no fragment required.